"Part fix" for the most prominent part of background overwrite issue #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue #13 5 Nov 2014 for background: #13 The extension also kills any other extension's attempt to manage tab background colours. Various extensions like Tab Mix Plus and ColorfulTabs control tab backgrounds, to show tab status or domain etc. VT just deletesw all these and overrides them, with what it considers "default colours". Two problems - 1) a user can't colour tabs for status etc if also using VT 2) VT doesn't have any place doing this - a user who wants to theme their tabs, can use themes, or a customisation extension. It's completely separate from vertical formatting the tab. Too hard to unpick everything but this fix at least stops VT killing the major part of other extensions colouring, on Windows. If a user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #13 5 Nov 2014 for background: #13
The extension also kills any other extension's attempt to manage tab background colours. Various extensions like Tab Mix Plus and ColorfulTabs control tab backgrounds, to show tab status or domain etc. VT just deletes all these and overrides them, with what it considers "default colours".
Two problems -
Too hard to unpick everything but this fix at least stops VT killing the major part of other extensions colouring, on Windows. Ideally please remove all tab theming from VT. Let other extensions do theming, if a user wants a theme, and don't override them.